Bug 442 – ACPI_BITREG_WAKE_ENABLE bit-defined Register Id usage should result in AE_BAD_PARAMETER

Bug 442 - ACPI_BITREG_WAKE_ENABLE bit-defined Register Id usage should result in AE_BAD_PARAMETER

Summary:

ACPI_BITREG_WAKE_ENABLE bit-defined Register Id usage should result in AE_BAD...

Status:	RESOLVED FIXED

Product:	ACPICA
Component:	Core/Interpreter
Version:	unspecified
Platform:	All Linux

Importance:	P4 normal
Assigned To:	Bob Moore

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-07-05 17:03 by Fiodor Suietov
Modified:	2008-09-26 19:56 (History)

Attachments
Proposed patch (495 bytes, text/plain) 2006-07-05 17:05, Fiodor Suietov	Details
proposed patch (2.69 KB, patch) 2008-09-08 00:48, Lin Ming	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Fiodor Suietov 2006-07-05 17:03:40

AcpiGetRegister and AcpiSetRegister ACPICA interfaces along
with other actual bit-defined Register Ids are specified to
deal with the manifest constant ACPI_BITREG_WAKE_ENABLE not
referring to any defined bit of the fixed ACPI h/w registers.

It is expected that call to them with the ACPI_BITREG_WAKE_ENABLE
Register Id should result in the exception code AE_BAD_PARAMETER.
Now it results in AE_OK.


INTERNAL API TS BUG NUMBER:

             30

------- Comment #1 From Fiodor Suietov 2006-07-05 17:05:27 -------

Created an attachment (id=503) [details]
Proposed patch

------- Comment #2 From Lin Ming 2008-09-08 00:34:14 -------

No any WAKE_ENABLE bit register defined in any version of ACPI spec
(1.0b-3.0a).
And ACPI_BITREG_WAKE_ENABLE is not used in any code.
How about just delete it?

------- Comment #3 From Lin Ming 2008-09-08 00:48:21 -------

Created an attachment (id=796) [details]
proposed patch

Remove ACPI_BITREG_WAKE_ENABLE since it's unused both in spec and in code.

------- Comment #4 From Bob Moore 2008-09-10 17:18:48 -------

Looks like ACPI_BITREG_WAKE_ENABLE was put there as a placeholder. I believe it
can and should be removed.

------- Comment #5 From Lin Ming 2008-09-26 19:56:51 -------

ship in ACPICA release 20080926