Bug 719 - [FreeBSD] Fixes for acfreebsd.h.
: [FreeBSD] Fixes for acfreebsd.h.
Status: RESOLVED FIXED
: ACPICA
Core/Interpreter
: unspecified
: All Linux
: P3 normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-05-22 15:12 by
Modified: 2008-06-17 15:38 (History)


Attachments
Suggested fixes for acfreebsd.h. (771 bytes, patch)
2008-05-22 15:18, Jung-uk Kim
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-05-22 15:12:55
Bug detailed description:
--------------------------

ACPI_THREAD_ID was added in acfreebsd.h as pid_t:

http://www.acpica.org/repos/?p=acpica.git;a=commitdiff;h=25f1dc9a8107603d00e1d56b80fe8c0073fa33c0

Then changed to uintptr_t:

http://www.acpica.org/repos/?p=acpica.git;a=commitdiff;h=500fff6f638f1da53eb7227b587aea2fa00227dc

However, it is actually struct thread * but FreeBSD OSL still returns pid_t.

Also, there is a typo.

Reproduce steps:
----------------

Compile ACPI-CA on FreeBSD.

Current result:        
----------------

Does not compile.

Expected result:    
----------------

Compile cleanly.

Basic root-causing log:
----------------------
------- Comment #1 From 2008-05-22 15:18:27 -------
Created an attachment (id=790) [details]
Suggested fixes for acfreebsd.h.

ACPI_THREAD_ID falls back to ACPI_SIZE (actypes.h) if it is undefined. 
Actually that is just fine for struct thread * if AcpiOsGetThreadId() casts
return value to ACPI_SIZE correctly.
------- Comment #2 From 2008-06-17 15:38:32 -------
17 June 2008 - integrated into ACPICA, will appear in next release.